Messages in this thread | | | Date | Tue, 20 Jun 2023 15:30:48 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 1/2] firmware: stratix10-svc: Support up to N SVC clients |
| |
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master] [also build test WARNING on v6.4-rc7 next-20230619] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/tien-sung-ang-intel-com/firmware-stratix10-svc-Support-up-to-N-SVC-clients/20230620-115443 base: linus/master patch link: https://lore.kernel.org/r/20230620035205.1158032-1-tien.sung.ang%40intel.com patch subject: [PATCH 1/2] firmware: stratix10-svc: Support up to N SVC clients config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306201523.U6yvKscG-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230620/202306201523.U6yvKscG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202306201523.U6yvKscG-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/firmware/stratix10-svc.c: In function 'stratix10_svc_free_channels': >> drivers/firmware/stratix10-svc.c:1149:21: warning: the comparison will always evaluate as 'true' for the address of 'svc_fifo' will never be NULL [-Waddress] 1149 | if (&ctrl->chans[i].svc_fifo) | ^ drivers/firmware/stratix10-svc.c:167:22: note: 'svc_fifo' declared here 167 | struct kfifo svc_fifo; | ^~~~~~~~
vim +1149 drivers/firmware/stratix10-svc.c
1138 1139 static void stratix10_svc_free_channels(struct stratix10_svc_controller *ctrl) 1140 { 1141 int i; 1142 1143 for (i = 0; i < SVC_NUM_CHANNEL; i++) { 1144 if (ctrl->chans[i].task) { 1145 kthread_stop(ctrl->chans[i].task); 1146 ctrl->chans[i].task = NULL; 1147 } 1148 > 1149 if (&ctrl->chans[i].svc_fifo) 1150 kfifo_free(&ctrl->chans[i].svc_fifo); 1151 } 1152 } 1153
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |