lkml.org 
[lkml]   [2023]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 0/4] Support timer drivers as loadable modules
From

As I already said, I'm not very comfortable with these changes and the
potential impact it can have on the overall time framework.

I will pick the series if Thomas gives its Acked-by

Thanks


On 17/05/2023 04:25, walter.chang@mediatek.com wrote:
> From: Walter Chang <walter.chang@mediatek.com>
>
> This set of patches aims to make SoC related timer drivers, such as
> timer-mediatek.c become loadable modules for the Generic Kernel Image
> (GKI).
>
> This driver registers an always-on timer as tick_broadcast_device on
> MediaTek SoCs. If the system does not load this module at startup,
> system will also boot normally by using built-in `bc_hrtimer` instead.
> Besides, the previous experiment [1] indicates that the SYST/GPT, in
> combination with a loadable module, is fully operational.
>
> The first three patches export functions and remove __init markings to
> support loadable timer modules.
>
> The fourth patch makes timer-mediatek.c become loadable module for GKI.
>
> [1]
> https://lore.kernel.org/all/32777456f8e0f98e4cd5b950f421d21f71b149cf.camel@mediatek.com/#t
>
> [v5]
> - Add Signed-off-by tags in all patches
> - Add Acked-by tags and Reviewed-by tags
>
> [v4]
> - Fix review comments pointed by Angelo
>
> [v3]
> - Rebase on linux-next
>
> [v2]
> - Convert timer-mediatek.c driver to loadable module
>
> Chun-Hung Wu (4):
> time/sched_clock: Export sched_clock_register()
> clocksource/drivers/mmio: Export clocksource_mmio_init()
> clocksource/drivers/timer-of: Remove __init markings
> clocksource/drivers/timer-mediatek: Make timer-mediatek become
> loadable module
>
> drivers/clocksource/Kconfig | 2 +-
> drivers/clocksource/mmio.c | 8 ++++---
> drivers/clocksource/timer-mediatek.c | 33 ++++++++++++++++++++++++++++
> drivers/clocksource/timer-of.c | 23 +++++++++----------
> drivers/clocksource/timer-of.h | 6 ++---
> kernel/time/sched_clock.c | 4 ++--
> 6 files changed, 56 insertions(+), 20 deletions(-)
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

\
 
 \ /
  Last update: 2023-06-19 18:44    [W:0.959 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site