Messages in this thread | | | Date | Mon, 19 Jun 2023 11:40:59 -0500 | From | Corey Minyard <> | Subject | Re: [PATCH] ipmi:ssif: Add check for kstrdup |
| |
On Mon, Jun 19, 2023 at 05:28:02PM +0800, Jiasheng Jiang wrote: > Add check for the return value of kstrdup() and return the error > if it fails in order to avoid NULL pointer dereference.
Thanks, this is in my next tree.
-corey
> > Fixes: c4436c9149c5 ("ipmi_ssif: avoid registering duplicate ssif interface") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/char/ipmi/ipmi_ssif.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 3b921c78ba08..3b87a2726e99 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1600,6 +1600,11 @@ static int ssif_add_infos(struct i2c_client *client) > info->addr_src = SI_ACPI; > info->client = client; > info->adapter_name = kstrdup(client->adapter->name, GFP_KERNEL); > + if (!info->adapter_name) { > + kfree(info); > + return -ENOMEM; > + } > + > info->binfo.addr = client->addr; > list_add_tail(&info->link, &ssif_infos); > return 0; > -- > 2.25.1 >
| |