Messages in this thread | | | Date | Mon, 19 Jun 2023 17:38:37 +0200 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: update i_version in update_dev_time |
| |
On Thu, Jun 15, 2023 at 08:49:45AM -0400, Jeff Layton wrote: > When updating the ctime, we also want to update i_version. > > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > fs/btrfs/volumes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > This is just something I noticed by inspection. There is probably no way > to test this today unless you can somehow get to this inode via nfsd. > Still, I think it's the right thing to do for consistency's sake.
I don't see anything wrong with setting the iversion bit, however I also don't see where this would be useful. Agreed with the consistency, otherwise the time is updated when device super block is wiped or a device initialized, both are big events so missing that due to lack of iversion update seems unlikely. I'll add it to the queue, thanks.
| |