Messages in this thread | | | Date | Mon, 19 Jun 2023 13:44:56 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v14 17/18] media: i2c: ds90ub953: Restructure clkout management |
| |
On Mon, Jun 19, 2023 at 01:14:34PM +0300, Tomi Valkeinen wrote: > On 16/06/2023 17:37, Andy Shevchenko wrote: > > On Fri, Jun 16, 2023 at 04:59:21PM +0300, Tomi Valkeinen wrote: > > > Separate clkout calculations and register writes into two functions: > > > ub953_calc_clkout_params and ub953_write_clkout_regs, and add a struct > > > ub953_clkout_data that is used to store the clkout parameters.
...
> > > +struct ub953_clkout_data { > > > + u32 hs_div; > > > + u32 m; > > > + u32 n; > > > > Please, use struxt u32_fract instead of m/n. > > I'm not sure how that helps. The documentation talks about m and n. Using > different terms will make it more difficult to compare the code and the > docs.
You can always add a comment.
(For example in drivers/clk/clk-fractional-divider.c our documentation also says about m/n, but most of the people understands that this is about fractional divider and actually with properly spelled parameters it will help others who are not experts in the CLK hardware.)
-- With Best Regards, Andy Shevchenko
| |