Messages in this thread | | | Subject | Re: [PATCH 1/3] [v2] sfc: add CONFIG_INET dependency for TC offload | From | Edward Cree <> | Date | Mon, 19 Jun 2023 11:04:55 +0100 |
| |
On 19/06/2023 10:12, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The driver now fails to link when CONFIG_INET is disabled, so > add an explicit Kconfig dependency: > > ld.lld: error: undefined symbol: ip_route_output_flow >>>> referenced by tc_encap_actions.c >>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_flower_create_encap_md) in archive vmlinux.a > > ld.lld: error: undefined symbol: ip_send_check >>>> referenced by tc_encap_actions.c >>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a >>>> referenced by tc_encap_actions.c >>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_gen_encap_header) in archive vmlinux.a > > ld.lld: error: undefined symbol: arp_tbl >>>> referenced by tc_encap_actions.c >>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a >>>> referenced by tc_encap_actions.c >>>> drivers/net/ethernet/sfc/tc_encap_actions.o:(efx_tc_netevent_event) in archive vmlinux.a > > Fixes: a1e82162af0b8 ("sfc: generate encap headers for TC offload") > Reviewed-by: Edward Cree <ecree.xilinx@gmail.com> > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306151656.yttECVTP-lkp@intel.com/ > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Additionally Fixes: 7e5e7d800011 ("sfc: neighbour lookup for TC encap action offload")
The subject line doesn't specify a target tree; this should be for net-next.
> --- > v2: add Fixes and Closes tags > --- > drivers/net/ethernet/sfc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig > index 4af36ba8906ba..3eb55dcfa8a61 100644 > --- a/drivers/net/ethernet/sfc/Kconfig > +++ b/drivers/net/ethernet/sfc/Kconfig > @@ -50,6 +50,7 @@ config SFC_MCDI_MON > config SFC_SRIOV > bool "Solarflare SFC9100-family SR-IOV support" > depends on SFC && PCI_IOV > + depends on INET > default y > help > This enables support for the Single Root I/O Virtualization >
| |