Messages in this thread | | | Date | Mon, 19 Jun 2023 11:55:06 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 4/6] watchdog/hardlockup: Make HAVE_NMI_WATCHDOG sparc64-specific |
| |
On Fri 2023-06-16 09:48:06, Doug Anderson wrote: > Hi, > > On Fri, Jun 16, 2023 at 8:07 AM Petr Mladek <pmladek@suse.com> wrote: > > > > There are several hardlockup detector implementations and several Kconfig > > values which allow selection and build of the preferred one. [...] > > Note that HARDLOCKUP_DETECTOR_PREFER_BUDDY, HARDLOCKUP_DETECTOR_PERF, > > and HARDLOCKUP_DETECTOR_BUDDY may conflict only with > > HAVE_HARDLOCKUP_DETECTOR_ARCH. They depend on HARDLOCKUP_DETECTOR > > and it is not longer enabled when HAVE_NMI_WATCHDOG is set. > > > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > > > watchdog/sparc64: Rename HAVE_NMI_WATCHDOG to HAVE_HARDLOCKUP_WATCHDOG_SPARC64 [...] > > Also the variable is set only on sparc64. Move the definition > > from arch/Kconfig to arch/sparc/Kconfig.debug. > > > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > I think you goofed up when squashing the patches. You've now got a > second patch subject after your first Signed-off-by and then a second > Signed-off-by... I assume everything after the first Signed-off-by > should be dropped?
Ah, you are right. It seems that Andrew has fixed this when taking the patch.
Thank you both, Petr
| |