Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 19 Jun 2023 09:43:52 +0200 | Subject | Re: [PATCH] gpiolib: Fix irq_domain resource tracking for gpiochip_irqchip_add_domain() |
| |
On Sat, Jun 17, 2023 at 4:25 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Jun 16, 2023 at 9:02 PM Michael Walle <michael@walle.cc> wrote: > > Am 2023-06-16 16:13, schrieb Andy Shevchenko: > > > On Fri, Jun 16, 2023 at 09:30:06AM +0200, Michael Walle wrote: > > ... > > > >> /* Remove all IRQ mappings and delete the domain */ > > >> - if (gc->irq.domain) { > > >> + if (!gc->irq.domain_is_ext && gc->irq.domain) { > > > > > > Looking at this, perhaps positive about allocation? > > > > > > domain_is_allocated? > > > > I mean all domains are allocated ;) > > > > domain_is_allocated_externally? I'm bad with short and concise > > names.. > > Naming is one of the hardest problems in software... > Your variant is long, but conscious. I dunno. Bart, Linus, do you have > any ideas?
No, this name is fine. It is meant for human readers and they will immediately understand.
Yours, Linus Walleij
| |