Messages in this thread | | | From | Paul Moore <> | Date | Mon, 19 Jun 2023 17:47:54 -0400 | Subject | Re: [PATCH] capabilities: fix sparse warning about __user access |
| |
On Mon, Jun 19, 2023 at 1:57 PM Serge E. Hallyn <serge@hallyn.com> wrote: > > On Mon, Jun 19, 2023 at 01:35:35PM +0100, Ben Dooks wrote: > > The two syscalls for capget and capset are producing sparse warnings > > as sparse is thinking that the "struct __user_cap_data_struct" is marked > > user, which seems to be down to the declaration and typedef at the same > > time. > > > > Fix the following warnings by splutting the struct declaration and then > > the user typedef into two: > > I'm not a fan of making code changes to work around scanners' > shortcomings, mainly because eventually I assume the scanners > will learn to deal with it. > > However, I don't like the all-in-one typedef+struct definition > either, so let's go with it :) > > Paul, do you mind picking this up?
Sure, no problem. Since we are at -rc7, I'm assuming this can wait until after the merge window?
-- paul-moore.com
| |