Messages in this thread | | | Date | Mon, 19 Jun 2023 09:29:16 +0200 | Subject | Re: [PATCH 1/6] dt-bindings: mmc: mmci: Add st,stm32mp25-sdmmc2 compatible | From | Yann Gautier <> |
| |
On 6/15/23 20:51, Linus Walleij wrote: > On Thu, Jun 15, 2023 at 5:19 PM Yann Gautier <yann.gautier@foss.st.com> wrote: > >>> - description: Entry for STMicroelectronics variant of PL18x. >>> This dedicated compatible is used by bootloaders. > (...) >>> - description: Entry for STMicroelectronics variant of PL18x for >>> STM32MP25. This dedicated compatible is used by bootloaders. > (...) >>> Should I remove (or adapt) both descriptions? >>> >>> >> >> At the time the patch was done it was really just used by bootloaders. >> But as it is now used in the driver for delay block, I should remove the >> second sentence. > > Remove both. > > After "This dedicated compatible is used by bootloaders" there is > an implicit "in the SDK provided by ST Microelectronics", and that > is of no concern for DT bindings, which are (well, in theory) used by > e.g. BSD or other operating systems and who knows what they will > use and not, we don't put Linux specifics in there, neither Boot > loader specifics nor ST SDK specifics. > > At least that is the little bureaucratic ambition we have. > > Yours, > Linus Walleij
Hi,
Thanks for all the reviews. I'll update this patch in the v2, removing bootloader line and using enum.
Ulf, should I send the new series now, or do you prefer to review the whole series before?
Yann
| |