lkml.org 
[lkml]   [2023]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] firmware: ti_sci: Use system_state to determine polling
On Mon, Jun 19, 2023 at 08:12:36AM -0500, Nishanth Menon wrote:
> Commit b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled
> mode during system suspend") aims to resolve issues with tisci
> operations during system suspend operation. However, the system may
> enter a no_irq stage in various other usage modes, including power-off
> and restart. To determine if polling mode is appropriate, use the
> system_state instead.
>
> While at this, drop the unused is_suspending state variable and
> related helpers.
>
> Reported-by: Francesco Dolcini <francesco@dolcini.it>
> Reported-by: Wadim Egorov <w.egorov@phytec.de>
> Link: https://lore.kernel.org/all/ZGeHMjlnob2GFyHF@francesco-nb.int.toradex.com/
> Signed-off-by: Nishanth Menon <nm@ti.com>

s/Link/Closes/

Fixes: b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled mode during system suspend")

> drivers/firmware/ti_sci.c | 35 ++---------------------------------
> 1 file changed, 2 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 039d92a595ec..dc7906e38f09 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
...
> -static DEFINE_SIMPLE_DEV_PM_OPS(ti_sci_pm_ops, ti_sci_suspend, ti_sci_resume);

You need to stop using ti_sci_pm_ops in ti_sci_driver, without this
change it does not build.

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index dc7906e38f09..91aaa0ca9bde 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -3485,7 +3485,6 @@ static struct platform_driver ti_sci_driver = {
.driver = {
.name = "ti-sci",
.of_match_table = of_match_ptr(ti_sci_of_match),
- .pm = &ti_sci_pm_ops,
},
};

With that change I was able to do a quick test on a patched v6.4-rc7 and
it seems to solve the issue.

Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Toradex Verdin AM62

Francesco

\
 
 \ /
  Last update: 2023-06-19 23:21    [W:0.025 / U:1.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site