lkml.org 
[lkml]   [2023]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional
On Mon, Jun 19, 2023 at 06:58:47PM +0530, Kamlesh Gurudasani wrote:
> Devices specific to compatible ti,am62-sa3ul don't have control over
> power of SA3UL from main domain.
>
> "power-domains" property in crypto node tries to access
> the SA3UL power, for which it gets NACK and hence, driver doesn't
> probe properly for those particular devices.
>
> Make "power-domains" property as false for devices with
> compatible ti,am62-sa3ul.
>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 77ec8bc70bf7..88c8ee8821d4 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,10 +66,22 @@ patternProperties:
> required:
> - compatible
> - reg
> - - power-domains
> - dmas
> - dma-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + items:

The usual pattern here is s/items/contains/. With that,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> + const: ti,am62-sa3ul
> + then:
> + properties:
> + power-domains: false
> + else:
> + required:
> + - power-domains
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.34.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-06-19 22:28    [W:0.026 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site