Messages in this thread | | | Date | Mon, 19 Jun 2023 15:41:20 -0400 | From | Peter Xu <> | Subject | Re: [PATCH 7/7] mm/gup: Retire follow_hugetlb_page() |
| |
On Sat, Jun 17, 2023 at 09:40:41PM +0100, Lorenzo Stoakes wrote: > On Tue, Jun 13, 2023 at 05:53:46PM -0400, Peter Xu wrote: > > Now __get_user_pages() should be well prepared to handle thp completely, > > as long as hugetlb gup requests even without the hugetlb's special path. > > > > Time to retire follow_hugetlb_page(). > > Nit, but there's a couple left over references to this function in comments > in fs/userfaultfd.c and mm/hugetlb.c.
Indeed, let me touch those too when respin.
> Absolutely wonderful to see such delightful code deletion :) > > I haven't really dug into the huge page side of this in great detail, so I > can't give a meaningful tag, but I can certainly appreciate the code you're > removing here!
Yeah, hopefully it'll make the code also cleaner. Thanks a lot,
-- Peter Xu
| |