lkml.org 
[lkml]   [2023]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: timers/core] posix-timers: Clarify posix_timer_rearm() comment
    The following commit has been merged into the timers/core branch of tip:

    Commit-ID: 02972d7955341b711d4c392f14faa9f9cd69d551
    Gitweb: https://git.kernel.org/tip/02972d7955341b711d4c392f14faa9f9cd69d551
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Tue, 25 Apr 2023 20:49:22 +02:00
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitterDate: Sun, 18 Jun 2023 22:41:52 +02:00

    posix-timers: Clarify posix_timer_rearm() comment

    Yet another incomprehensible piece of art.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
    Link: https://lore.kernel.org/r/20230425183313.724863461@linutronix.de

    ---
    kernel/time/posix-timers.c | 12 +++---------
    1 file changed, 3 insertions(+), 9 deletions(-)

    diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
    index c8b0f52..d8d2169 100644
    --- a/kernel/time/posix-timers.c
    +++ b/kernel/time/posix-timers.c
    @@ -275,15 +275,9 @@ static void common_hrtimer_rearm(struct k_itimer *timr)
    }

    /*
    - * This function is exported for use by the signal deliver code. It is
    - * called just prior to the info block being released and passes that
    - * block to us. It's function is to update the overrun entry AND to
    - * restart the timer. It should only be called if the timer is to be
    - * restarted (i.e. we have flagged this in the sys_private entry of the
    - * info block).
    - *
    - * To protect against the timer going away while the interrupt is queued,
    - * we require that the it_requeue_pending flag be set.
    + * This function is called from the signal delivery code if
    + * info->si_sys_private is not zero, which indicates that the timer has to
    + * be rearmed. Restart the timer and update info::si_overrun.
    */
    void posixtimer_rearm(struct kernel_siginfo *info)
    {
    \
     
     \ /
      Last update: 2023-06-18 22:51    [W:5.274 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site