lkml.org 
[lkml]   [2023]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf annotate: Work with vmlinux outside symfs
Date
On Fri, 2022-11-25 at 12:42 +0100, Vincent Whitchurch wrote:
> It is currently possible to use --symfs along with a vmlinux which lies
> outside of the symfs by passing an absolute path to --vmlinux, thanks to
> the check in dso__load_vmlinux() which handles this explicitly.
>
> However, the annotate code lacks this check and thus perf annotate does
> not work ("Internal error: Invalid -1 error code") for kernel functions
> with this combination. Add the missing handling.
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

This patch was not merged and I did not receive any comments on it
either. Should I resend it? It still applies cleanly to current
mainline. Thanks.

\
 
 \ /
  Last update: 2023-06-16 12:24    [W:0.093 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site