Messages in this thread | | | Date | Fri, 16 Jun 2023 11:42:46 +0200 | Subject | Re: [PATCH] mm: vmscan: export func:shrink_slab | From | David Hildenbrand <> |
| |
On 16.06.23 11:21, lipeifeng@oppo.com wrote: > From: lipeifeng <lipeifeng@oppo.com> > > Some of shrinkers during shrink_slab would enter synchronous-wait > due to lock or other reasons, which would causes kswapd or > direct_reclaim to be blocked. > > This patch export shrink_slab so that it can be called in drivers > which can shrink memory independently. > > Signed-off-by: lipeifeng <lipeifeng@oppo.com> > --- > mm/vmscan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 6d0cd2840cf0..2e54fa52e7ec 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1043,7 +1043,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > * > * Returns the number of reclaimed slab objects. > */ > -static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > +unsigned long shrink_slab(gfp_t gfp_mask, int nid, > struct mem_cgroup *memcg, > int priority) > { > @@ -1087,6 +1087,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > cond_resched(); > return freed; > } > +EXPORT_SYMBOL_GPL(shrink_slab); > > static unsigned long drop_slab_node(int nid) > {
It feels like something we don't want arbitrary drivers to call.
Unrelated to that, this better be sent along with actual driver usage.
-- Cheers,
David / dhildenb
| |