Messages in this thread | | | Date | Fri, 16 Jun 2023 12:32:40 +0530 | From | Ravi Bangoria <> | Subject | Re: [PATCH v3 1/3] perf test: Add metric value validation test |
| |
Hi,
> diff --git a/tools/perf/tests/shell/stat_metrics_values.sh b/tools/perf/tests/shell/stat_metrics_values.sh > new file mode 100755 > index 000000000000..65a15c65eea7 > --- /dev/null > +++ b/tools/perf/tests/shell/stat_metrics_values.sh > @@ -0,0 +1,30 @@ > +#!/bin/bash > +# perf metrics value validation > +# SPDX-License-Identifier: GPL-2.0 > +if [ "x$PYTHON" == "x" ] > +then > + if which python3 > /dev/null > + then > + PYTHON=python3 > + else > + echo Skipping test, python3 not detected please set environment variable PYTHON. > + exit 2 > + fi > +fi > + > +grep -q Intel /proc/cpuinfo || (echo Skipping non-Intel; exit 2)
This check doesn't seem to be working. On my Zen3 AMD machine:
$ sudo ./perf test -vvv 105 105: perf metrics value validation : --- start --- test child forked, pid 518035 Skipping non-Intel Launch python validation script ./tests/shell/lib/perf_metric_validation.py Output will be stored in: /tmp/__perf_test.program.tnPoW Starting perf collection ...
Interestingly, it passes :)
... Test validation finished. Final report: [ { "Workload": "perf bench futex hash -r 2 -s", "Report": { "Metric Validation Statistics": { "Total Rule Count": 2, "Passed Rule Count": 2 }, "Tests in Category": { "PositiveValueTest": { "Total Tests": 12, "Passed Tests": 12, "Failed Tests": [] }, "RelationshipTest": { "Total Tests": 0, "Passed Tests": 0, "Failed Tests": [] }, "SingleMetricTest": { "Total Tests": 2, "Passed Tests": 2, "Failed Tests": [] } }, "Errors": [] } } ] test child finished with 0 ---- end ---- perf metrics value validation: Ok
I haven't yet investigated whether it's genuine or false positive.
Thanks, Ravi
| |