lkml.org 
[lkml]   [2023]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v1 04/14] net: phy: nxp-c45-tja11xx: add *_reg_field functions
> +static int nxp_c45_read_reg_field(struct phy_device *phydev,
> + const struct nxp_c45_reg_field *reg_field)
> +{
> + u16 mask;
> + int ret;
> +
> + if (reg_field->size == 0) {
> + phydev_warn(phydev, "Trying to read a reg field of size 0.");

I would actually use phydev_err().

> + if (reg_field->size == 0) {
> + phydev_warn(phydev, "Trying to write a reg field of size 0.");

Here as well.


Andrew

---
pw-bot: cr

\
 
 \ /
  Last update: 2023-06-16 22:43    [W:0.338 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site