Messages in this thread | | | From | Jose Abreu <> | Subject | RE: [net-next PATCH v5 4/5] net: ethernet: stmicro: stmmac: generate stmmac dma conf before open | Date | Wed, 14 Jun 2023 13:48:40 +0000 |
| |
From: Christian Marangi <ansuelsmth@gmail.com> Date: Wed, Jun 14, 2023 at 03:16:08
> I'm not following the meaning of leak here. If it's intended as a memory > leak then dma_conf is correctly freed in the 2 user of __stmmac_open. > > stmmac_init_phy also doesn't seems to use dma_conf. Am I missing > something here? >
Sorry, I should have been clearer: It's not leaking the dma_conf per-se but the contents of it: The DMA descriptors. Since the memcpy() is only done after init_phy(); if init_phy() fails, then stmmac will never free up the DMA descriptors.
Does it make sense?
Thanks, Jose
| |