Messages in this thread | | | Date | Wed, 14 Jun 2023 09:09:10 -0700 | Subject | Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning | From | Randy Dunlap <> |
| |
On 6/7/23 05:08, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Since usermodehelper_table() is marked static now, we get a > warning about it being unused when SYSCTL is disabled: > > kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function] > > Just move it inside of the same #ifdef. > > Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> --- > kernel/umh.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/umh.c b/kernel/umh.c > index d5dc3cc92d5c6..2f9249c2bf6ce 100644 > --- a/kernel/umh.c > +++ b/kernel/umh.c > @@ -494,6 +494,7 @@ int call_usermodehelper(const char *path, char **argv, char **envp, int wait) > } > EXPORT_SYMBOL(call_usermodehelper); > > +#if defined(CONFIG_SYSCTL) > static int proc_cap_handler(struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > @@ -544,7 +545,6 @@ static int proc_cap_handler(struct ctl_table *table, int write, > return 0; > } > > -#if defined(CONFIG_SYSCTL) > static struct ctl_table usermodehelper_table[] = { > { > .procname = "bset",
-- ~Randy
| |