lkml.org 
[lkml]   [2023]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource()
Hi Ye,

On Sat, Jan 28, 2023 at 02:51:44PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/i2c/busses/i2c-wmt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
> index 7d4bc8736079..4a3e3985e418 100644
> --- a/drivers/i2c/busses/i2c-wmt.c
> +++ b/drivers/i2c/busses/i2c-wmt.c
> @@ -372,7 +372,6 @@ static int wmt_i2c_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct wmt_i2c_dev *i2c_dev;
> struct i2c_adapter *adap;
> - struct resource *res;
> int err;
> u32 clk_rate;
>
> @@ -380,8 +379,7 @@ static int wmt_i2c_probe(struct platform_device *pdev)
> if (!i2c_dev)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c_dev->base = devm_ioremap_resource(&pdev->dev, res);
> + i2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

It's also a cleaner way to handle the error when res is NULL.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi

> if (IS_ERR(i2c_dev->base))
> return PTR_ERR(i2c_dev->base);
>
> --
> 2.25.1

\
 
 \ /
  Last update: 2023-06-10 15:43    [W:0.044 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site