Messages in this thread | | | Date | Thu, 1 Jun 2023 19:03:41 +0200 | Subject | Re: [PATCH] w1: sgi_w1: Replace all non-returning strlcpy with strscpy | From | Krzysztof Kozlowski <> |
| |
On 31/05/2023 01:06, Kees Cook wrote: > On Tue, 23 May 2023 02:20:23 +0000, Azeem Shaikh wrote: >> strlcpy() reads the entire source buffer first. >> This read may exceed the destination size limit. >> This is both inefficient and can lead to linear read >> overflows if a source string is not NUL-terminated [1]. >> In an effort to remove strlcpy() completely [2], replace >> strlcpy() here with strscpy(). >> No return values were used, so direct replacement is safe. >> >> [...] > > Applied to for-next/hardening, thanks! > > [1/1] w1: sgi_w1: Replace all non-returning strlcpy with strscpy > https://git.kernel.org/kees/c/4e4424b20cc4
Please drop. This was already fixed and is in linux-next since almost a month:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git/commit/?h=for-next&id=5dfd3c73ff81618fee0ef682b6fd7779863f41e4
>
Best regards, Krzysztof
| |