lkml.org 
[lkml]   [2023]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode
    On 2023-05-08 16:17:54, Jessica Zhang wrote:
    <snip>
    > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h
    > >> index 73b0885918f8..a8def68a5ec2 100644
    > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h
    > >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h
    > >> @@ -70,6 +70,7 @@ struct intf_status {
    > >> * @get_autorefresh: Retrieve autorefresh config from hardware
    > >> * Return: 0 on success, -ETIMEDOUT on timeout
    > >> * @vsync_sel: Select vsync signal for tear-effect configuration
    > >> + * @enable_compression: Enable data compression
    > >
    > > Indent to match above.
    >
    > Sure, is the plan to correct the whitespace in the first half of the
    > comment block in the future?

    I couldn't see the first part of the block in the diff context here, but
    indeed that's a broken disaster so we will have to fix that up :(

    I think it is fine to leave the latter ones as it is, as long as it is
    consistent:

    - Only using spaces;
    - Colon directly after the word (and an @ before it, see kerneldoc
    specification);
    - Aligned to existing entries.

    - Marijn

    \
     
     \ /
      Last update: 2023-05-09 08:47    [W:3.750 / U:1.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site