Messages in this thread | | | From | Zi Yan <> | Subject | Re: [PATCH 2/2] migrate_pages_batch: code cleanup: remove is_large | Date | Tue, 09 May 2023 10:26:40 -0400 |
| |
On 8 May 2023, at 22:20, Huang Ying wrote:
> Previously, in migrate_pages_batch we need to track whether the source > folio is large/THP before splitting. So is_large is used to cache > folio_test_large() result. Now, we don't need that variable any more > because we don't count retrying and failure of large folios (only > counting that of THP folios). So, in this patch, is_large is removed > to simplify the code. > > This is just code cleanup, no functionality changes are expected. > > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > Cc: Xin Hao <xhao@linux.alibaba.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Yang Shi <shy828301@gmail.com> > Cc: Baolin Wang <baolin.wang@linux.alibaba.com> > Cc: Oscar Salvador <osalvador@suse.de> > Cc: Alistair Popple <apopple@nvidia.com> > --- > mm/migrate.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) >
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
-- Best Regards, Yan, Zi [unhandled content-type:application/pgp-signature] | |