lkml.org 
[lkml]   [2023]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parisc: kexec: include reboot.h
On 05/09/23 at 09:01am, Simon Horman wrote:
> Include reboot.h in machine_kexec.c for declaration of
> machine_crash_shutdown and machine_shutdown.
>
> gcc-12 with W=1 reports:
>
> arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> 57 | void machine_crash_shutdown(struct pt_regs *regs)
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> 61 | void machine_shutdown(void)
> | ^~~~~~~~~~~~~~~~
>
> No functional changes intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>

Acked-by: Baoquan He <bhe@redhat.com>

We may need to find out the places in all architectures and fix all of
them.

> ---
> arch/parisc/kernel/kexec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/parisc/kernel/kexec.c b/arch/parisc/kernel/kexec.c
> index 5eb7f30edc1f..db57345a9daf 100644
> --- a/arch/parisc/kernel/kexec.c
> +++ b/arch/parisc/kernel/kexec.c
> @@ -4,6 +4,8 @@
> #include <linux/console.h>
> #include <linux/kexec.h>
> #include <linux/delay.h>
> +#include <linux/reboot.h>
> +
> #include <asm/cacheflush.h>
> #include <asm/sections.h>
>
>

\
 
 \ /
  Last update: 2023-05-09 11:03    [W:0.057 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site