Messages in this thread | | | Date | Tue, 09 May 2023 08:56:27 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 1/2] ARM: perf: Mark all accessor functions inline |
| |
On Mon, 08 May 2023 17:05:18 +0100, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > When just including <asm/arm_pmuv3.h>: > > arch/arm/include/asm/arm_pmuv3.h:110:13: error: ‘write_pmevtypern’ defined but not used [-Werror=unused-function] > 110 | static void write_pmevtypern(int n, unsigned long val) > | ^~~~~~~~~~~~~~~~ > arch/arm/include/asm/arm_pmuv3.h:103:13: error: ‘write_pmevcntrn’ defined but not used [-Werror=unused-function] > 103 | static void write_pmevcntrn(int n, unsigned long val) > | ^~~~~~~~~~~~~~~ > arch/arm/include/asm/arm_pmuv3.h:95:22: error: ‘read_pmevcntrn’ defined but not used [-Werror=unused-function] > 95 | static unsigned long read_pmevcntrn(int n) > | ^~~~~~~~~~~~~~ > > Fix this by adding the missing "inline" keywords to the three accessor > functions that lack them. > > Fixes: 009d6dc87a568db6 ("ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
-- Without deviation from the norm, progress is not possible.
| |