Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 8 May 2023 12:55:28 +0200 | Subject | Re: [PATCH 2/2] sh: dma: Correct the number of DMA channels in SH7709 |
| |
On Sat, May 6, 2023 at 4:22 PM Artur Rojek <contact@artur-rojek.eu> wrote: > According to the PM, the DMAC found in SH7709 features only 4 channels. > > Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/sh/drivers/dma/Kconfig > +++ b/arch/sh/drivers/dma/Kconfig > @@ -28,8 +28,9 @@ config SH_DMA_API > config NR_ONCHIP_DMA_CHANNELS > int > depends on SH_DMA > - default "4" if CPU_SUBTYPE_SH7750 || CPU_SUBTYPE_SH7751 || \ > - CPU_SUBTYPE_SH7750S || CPU_SUBTYPE_SH7091 > + default "4" if CPU_SUBTYPE_SH7709 || CPU_SUBTYPE_SH7750 || \ > + CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7750S || \ > + CPU_SUBTYPE_SH7091 > default "8" if CPU_SUBTYPE_SH7750R || CPU_SUBTYPE_SH7751R || \ > CPU_SUBTYPE_SH7760 > default "12" if CPU_SUBTYPE_SH7723 || CPU_SUBTYPE_SH7780 || \ > @@ -37,8 +38,9 @@ config NR_ONCHIP_DMA_CHANNELS > default "6" > help > This allows you to specify the number of channels that the on-chip > - DMAC supports. This will be 4 for SH7750/SH7751/Sh7750S/SH7091 and 8 for the
Might be a good opportunity to s/Sh7750S/SH7750S/
> - SH7750R/SH7751R/SH7760, 12 for the SH7723/SH7780/SH7785/SH7724, default is 6. > + DMAC supports. This will be 4 for SH7709/SH7750/SH7751/Sh7750S/SH7091 > + and 8 for the SH7750R/SH7751R/SH7760, 12 for the SH7723/SH7780/SH7785/SH7724,
... and sort the list for SoCs with 12 channels.
> + default is 6. > > config SH_DMABRG > bool "SH7760 DMABRG support"
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |