Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v3 2/5] spi: sun6i: change OF match data to a struct | Date | Mon, 8 May 2023 09:47:36 +0000 |
| |
From: Maksim Kiselev > Sent: 07 May 2023 00:26 > > As we're adding more properties to the OF match data, convert it to a > struct now. > ... > - sspi->fifo_depth = (unsigned long)of_device_get_match_data(&pdev->dev); > + sspi->cfg = of_device_get_match_data(&pdev->dev);
Is it worth doing a structure copy at this point? The 'cfg' data is short and constant and it would make the code that uses it smaller and faster.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |