Messages in this thread | | | Date | Mon, 8 May 2023 23:47:59 +0200 | From | Marijn Suijten <> | Subject | Re: [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag |
| |
On 2023-05-07 22:21:35, Dmitry Baryshkov wrote: <snip> > > Konrad: Your SM6350/SM6375 series v3 [1] switched from INTF_SC7180_MASK > > to INTF_SC7280_MASK to enable HCTL on SM6375, but that will now > > erroneously also receive this feature flag and write the new > > DATA_COMPESS mask even if it's DPU 6.9 (< 7.x where it got added). > > Yeah, that's why I had the idea of including at least the DPU major in > the mask name.
Yes please, that would be much more clear. We could even drop the SoC name altogether.
> It looks like we should enable DPU_DATA_HCTL_EN at least for > sm8150/sm8250 (and other DPU 6.x) too. I am not sure if it is present on > sdm845.
Agreed, thanks for sending that patch!
<snip>
- Marijn
| |