| Date | Fri, 5 May 2023 23:09:53 +0000 | From | Eric Biggers <> | Subject | Re: [PATCH v6 08/12] x86/PM/keylocker: Restore internal wrapping key on resume from ACPI S3/4 |
| |
On Mon, Apr 10, 2023 at 03:59:32PM -0700, Chang S. Bae wrote: > +/* > + * This flag is set with IWKey load. When the key restore fails, it is > + * reset. This restore state is exported to the crypto library, then AES-KL > + * will not be used there. So, the feature is soft-disabled with this flag. > + */ > +static bool valid_kl; > + > +bool valid_keylocker(void) > +{ > + return valid_kl; > +} > +EXPORT_SYMBOL_GPL(valid_keylocker);
It would be simpler to export this bool directly.
> + if (status & BIT(0)) > + return 0; > + else > + return -EBUSY; [...] > + pr_info("x86/keylocker: Enabled.\n"); > + return; > + } else { > + int rc;
The kernel coding style usually doesn't use 'else' after a return.
- Eric
|