Messages in this thread | | | Date | Fri, 5 May 2023 12:26:58 +0530 | Subject | Re: [PATCH v5 2/3] pinctrl: qcom: Refactor target specific pinctrl driver | From | Rohit Agarwal <> |
| |
On 5/3/2023 7:23 PM, Andy Shevchenko wrote: > On Wed, May 3, 2023 at 2:14 PM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: >> On 5/3/2023 3:11 PM, Andy Shevchenko wrote: >>> On Wed, May 3, 2023 at 8:39 AM Rohit Agarwal <quic_rohiagar@quicinc.com> wrote: > ... > >>>> /** >>>> * struct msm_function - a pinmux function >>>> - * @name: Name of the pinmux function. >>>> - * @groups: List of pingroups for this function. >>>> - * @ngroups: Number of entries in @groups. >>>> + * @func: Generic data of the pin function (name and groups of pins) >>>> */ >>>> struct msm_function { >>>> - const char *name; >>>> - const char * const *groups; >>>> - unsigned ngroups; >>>> + struct pinfunction func; >>>> }; >>> But why? Just kill the entire structure. >> Got it. Can we have a typedef for pinfunction to msm_function in the msm >> header file? > But why? You can replace the type everywhere it needs to be replaced. > I can't expect many lines to change. > > Also consider splitting struct pingroup change out of this. We will > focus only on the struct pinfunction change and less code to review. Ok Will update all of this.
Thanks, Rohit.
| |