lkml.org 
[lkml]   [2023]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] net: phy: motorcomm: Add pad drive strength cfg support
    >  #define YTPHY_DTS_OUTPUT_CLK_DIS		0
    > @@ -1495,6 +1504,7 @@ static int yt8531_config_init(struct phy_device *phydev)
    > {
    > struct device_node *node = phydev->mdio.dev.of_node;
    > int ret;
    > + u32 ds, val;

    Reverse Christmas tree. Sort these longest first, shortest last.

    Otherwise this looks O.K.

    The only open question is if real unit should be used, uA, not some
    magic numbers. Lets see what the DT Maintainers say.

    Andrew

    \
     
     \ /
      Last update: 2023-05-05 15:19    [W:2.999 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site