Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH net-next] wifi: ath11k: Use list_count_nodes() | Date | Fri, 05 May 2023 16:06:46 +0300 |
| |
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> ath11k_wmi_fw_stats_num_vdevs() and ath11k_wmi_fw_stats_num_bcn() really > look the same as list_count_nodes(), so use the latter instead of hand > writing it. > > The first ones use list_for_each_entry() and the other list_for_each(), but > they both count the number of nodes in the list. > > While at it, also remove to prototypes of non-existent functions. > Based on the names and prototypes, it is likely that they should be > equivalent to list_count_nodes(). > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Un-tested
BTW I prefer to have "Compile tested only" in the commit log to make it clear that it's not tested on a real device. So I added that sentence to both this and ath10k patch.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |