lkml.org 
[lkml]   [2023]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH 01/11] rust: add radix tree abstraction
    Date

    Matthew Wilcox <willy@infradead.org> writes:

    > On Wed, May 03, 2023 at 11:06:58AM +0200, Andreas Hindborg wrote:
    >> From: Andreas Hindborg <a.hindborg@samsung.com>
    >>
    >> Add abstractions for the C radix_tree. This abstraction allows Rust code to use
    >> the radix_tree as a map from `u64` keys to `ForeignOwnable` values.
    >
    > Please, no. The XArray interface is the preferred one; the radix tree
    > is legacy. Don't make Rust code use the radix tree. It has the GFP
    > arguments in the wrong place, for one thing.

    I have a similar argument to not using xarrray as to not using folios,
    see my other response. But the Rust xarray API is in the works [1].

    Best regards,
    Andreas

    [1] https://lore.kernel.org/rust-for-linux/1bb98ef1-727a-45d6-3cf6-39765fe99c5c@asahilina.net/

    \
     
     \ /
      Last update: 2023-05-05 06:54    [W:5.026 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site