lkml.org 
[lkml]   [2023]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] dt-bindings: dma: ti: Add J721S2 BCDMA
From
On 03/05/2023 08:53, Vaishnav Achath wrote:
> Add bindings for J721S2 BCDMA instance dedicated for Camera
> Serial Interface. Unlike AM62A CSI BCDMA, this instance has RX
> and TX channels but lacks block copy channels.
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index beecfe7a1732..5ca9581a66f4 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -33,6 +33,7 @@ properties:
> enum:
> - ti,am62a-dmss-bcdma-csirx
> - ti,am64-dmss-bcdma
> + - ti,j721s2-dmss-bcdma-csi
>
> reg:
> minItems: 3
> @@ -150,7 +151,27 @@ allOf:
>
> required:
> - power-domains
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,j721s2-dmss-bcdma-csi
> + then:
> + properties:
> + ti,sci-rm-range-bchan: false
> +
> + reg:
> + maxItems: 4
>
> + reg-names:
> + items:
> + - const: gcfg
> + - const: rchanrt
> + - const: tchanrt
> + - const: ringrt
> +
> + required:
> + - ti,sci-rm-range-tchan
> else:
> properties:


You now require 5 reg items on ti,am62a-dmss-bcdma-csirx. I don't think
you tested your DTS against this change. Rework the else: so it will
match specific variant (if:).

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-05-04 19:04    [W:0.045 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site