Messages in this thread | | | Date | Wed, 31 May 2023 10:59:14 +0200 | From | Neil Armstrong <> | Subject | Re: [PATCH] firmware: meson_sm: Fix memcpy vs iomem type warnings |
| |
On 17/05/2023 20:25, Kees Cook wrote: > *thread necromancy* > > On Mon, Oct 17, 2022 at 05:25:13PM +0200, Neil Armstrong wrote: >> Hi, >> >> On Wed, 12 Oct 2022 11:53:16 -0700, Kees Cook wrote: >>> Use memcpy_{toio,fromio}() instead of memcpy(). Silences warnings from >>> Sparse: >>> >>> drivers/firmware/meson/meson_sm.c:170:17: warning: incorrect type in argument 1 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:170:17: expected void const * >>> drivers/firmware/meson/meson_sm.c:170:17: got void [noderef] __iomem *sm_shmem_out_base >>> drivers/firmware/meson/meson_sm.c:170:17: warning: incorrect type in argument 2 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:170:17: expected void const * >>> drivers/firmware/meson/meson_sm.c:170:17: got void [noderef] __iomem *sm_shmem_out_base >>> drivers/firmware/meson/meson_sm.c:206:9: warning: incorrect type in argument 1 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:206:9: expected void const * >>> drivers/firmware/meson/meson_sm.c:206:9: got void [noderef] __iomem *sm_shmem_in_base >>> drivers/firmware/meson/meson_sm.c:206:9: warning: incorrect type in argument 1 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:206:9: expected void const * >>> drivers/firmware/meson/meson_sm.c:206:9: got void [noderef] __iomem *sm_shmem_in_base >>> drivers/firmware/meson/meson_sm.c:206:9: warning: incorrect type in argument 1 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:206:9: expected void const * >>> drivers/firmware/meson/meson_sm.c:206:9: got void [noderef] __iomem *sm_shmem_in_base >>> drivers/firmware/meson/meson_sm.c:206:9: warning: incorrect type in argument 1 (different address spaces) >>> drivers/firmware/meson/meson_sm.c:206:9: expected void * >>> drivers/firmware/meson/meson_sm.c:206:9: got void [noderef] __iomem *sm_shmem_in_base >>> >>> [...] >> >> Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.2/drivers) >> >> [1/1] firmware: meson_sm: Fix memcpy vs iomem type warnings >> https://git.kernel.org/amlogic/c/7dc69c7d073e6004a281db8f7f15cf6ebf702ea0 >> >> These changes has been applied on the intermediate git tree [1]. >> >> The v6.2/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers >> for inclusion in their intermediate git branches in order to be sent to Linus during >> the next merge window, or sooner if it's a set of fixes. >> >> In the cases of fixes, those will be merged in the current release candidate >> kernel and as soon they appear on the Linux master branch they will be >> backported to the previous Stable and Long-Stable kernels [2]. >> >> The intermediate git branches are merged daily in the linux-next tree [3], >> people are encouraged testing these pre-release kernels and report issues on the >> relevant mailing-lists. >> >> If problems are discovered on those changes, please submit a signed-off-by revert >> patch followed by a corrective changeset. >> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git >> [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git >> [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > Hi! This change seems to have never been mainlined and seems to have > disappeared from linux-next. > Hi,
Indeed it was rejected by Arnd, but I failed to find time to investigate how to fix it
https://lore.kernel.org/all/4a6b34ef-f5d2-4e56-a7f6-6a7c9cdda416@app.fastmail.com/
Neil
| |