Messages in this thread | | | Date | Wed, 31 May 2023 19:03:26 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] isa: Remove unnecessary checks |
| |
On Thu, May 18, 2023 at 09:46:21PM -0400, William Breathitt Gray wrote: > On Wed, May 17, 2023 at 03:50:25PM +0300, Vladislav Efanov wrote: > > The isa_dev->dev.platform_data is initialized with incoming > > parameter isa_driver. After it isa_dev->dev.platform_data is > > checked for NULL, but incoming parameter isa_driver is not > > NULL since it is dereferenced many times before this check. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: a5117ba7da37 ("[PATCH] Driver model: add ISA bus") > > Signed-off-by: Vladislav Efanov <VEfanov@ispras.ru> > > I don't think the Fixes line is needed because this is removing a > superfluous check rather than fixing a bug. Regardless, here's my Ack > for Greg as the patch itself makes sense. > > Acked-by: William Breathitt Gray <william.gray@linaro.org>
Yes, the Fixes line makes no sense at all. I'll delete it when applying, thanks for the review.
greg k-h
| |