Messages in this thread Patch in this message | | | From | "Verma, Vishal L" <> | Subject | Re: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc | Date | Wed, 3 May 2023 17:57:52 +0000 |
| |
On Fri, 2023-04-28 at 01:22 +0000, Raghu H wrote: > Issue found with checkpatch > > A return of errno should be good enough if the memory allocation > fails, > the error message here is redundatant as per the coding style, > removing it. > > Signed-off-by: Raghu H <raghuhack78@gmail.com> > --- > drivers/cxl/core/mbox.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)
Looks good, Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index f2addb457172..11ea145b4b1f 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1112,10 +1112,8 @@ struct cxl_dev_state > *cxl_dev_state_create(struct device *dev) > struct cxl_dev_state *cxlds; > > cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL); > - if (!cxlds) { > - dev_err(dev, "No memory available\n"); > + if (!cxlds) > return ERR_PTR(-ENOMEM); > - } > > mutex_init(&cxlds->mbox_mutex); > mutex_init(&cxlds->event.log_lock);
| |