lkml.org 
[lkml]   [2023]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/40] change alloc_pages name in dma_map_ops to avoid name conflicts
    On Mon,  1 May 2023 09:54:29 -0700
    Suren Baghdasaryan <surenb@google.com> wrote:

    > After redefining alloc_pages, all uses of that name are being replaced.
    > Change the conflicting names to prevent preprocessor from replacing them
    > when it's not intended.

    Note, every change log should have enough information in it to know why it
    is being done. This says what the patch does, but does not fully explain
    "why". It should never be assumed that one must read other patches to get
    the context. A year from now, investigating git history, this may be the
    only thing someone sees for why this change occurred.

    The "why" above is simply "prevent preprocessor from replacing them
    when it's not intended". What does that mean?

    -- Steve


    >
    > Signed-off-by: Suren Baghdasaryan <surenb@google.com>

    \
     
     \ /
      Last update: 2023-05-03 18:26    [W:3.410 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site