Messages in this thread | | | Date | Wed, 3 May 2023 08:59:13 -0500 | Subject | Re: [PATCH v2] xhci-pci: Only run d3cold avoidance quirk for s2idle | From | "Limonciello, Mario" <> |
| |
On 5/3/2023 8:14 AM, Mathias Nyman wrote: > On 25.4.2023 0.48, Mario Limonciello wrote: >> Donghun reports that a notebook that has an AMD Ryzen 5700U but supports >> S3 has problems with USB after resuming from suspend. The issue was >> bisected down to commit d1658268e439 ("usb: pci-quirks: disable >> D3cold on >> xhci suspend for s2idle on AMD Renoir"). >> >> As this issue only happens on S3, narrow the broken D3cold quirk to only >> run in s2idle. >> >> Fixes: d1658268e439 ("usb: pci-quirks: disable D3cold on xhci suspend >> for s2idle on AMD Renoir") >> Reported-and-tested-by: Donghun Yoon <donghun.yoon@lge.com> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> >> --- >> v1->v2: >> * Guard against CONFIG_SUSPEND not being set > > Thanks, > Checkpatch complains that it wants a link to the issue after a > "Reported-by:" tag. > > Is there any public report of this? > > Thanks > Mathias > > It was reported privately to me by Donghun, and they confirmed from private testing that this change helps the issue.
I noticed that message from checkpatch too before I sent this up, but I figured it's better to give Donghun attribution rather than drop the tag.
| |