Messages in this thread | | | From | "Gaddam, Sarath Babu Naidu" <> | Subject | RE: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml | Date | Wed, 3 May 2023 09:30:37 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, May 2, 2023 3:56 PM > To: Gaddam, Sarath Babu Naidu > <sarath.babu.naidu.gaddam@amd.com>; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org > Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; > netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, > Anirudha <anirudha.sarangi@amd.com>; Katakam, Harini > <harini.katakam@amd.com>; git (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: > convert bindings document to yaml > > On 28/03/2023 14:52, Gaddam, Sarath Babu Naidu wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Tuesday, March 14, 2023 9:22 PM > >> To: Gaddam, Sarath Babu Naidu > >> <sarath.babu.naidu.gaddam@amd.com>; davem@davemloft.net; > >> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org > >> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; > >> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, > >> Anirudha <anirudha.sarangi@amd.com>; Katakam, Harini > >> <harini.katakam@amd.com>; git (AMD-Xilinx) <git@amd.com> > >> Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: > >> convert bindings document to yaml > >> > >> On 08/03/2023 07:12, Sarath Babu Naidu Gaddam wrote: > >>> From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > >>> > >>> Convert the bindings document for Xilinx AXI Ethernet Subsystem > from > >>> txt to yaml. No changes to existing binding description. > >>> > >> > >> (...) > >> > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - xlnx,axi-ethernet-1.00.a > >>> + - xlnx,axi-ethernet-1.01.a > >>> + - xlnx,axi-ethernet-2.01.a > >>> + > >>> + reg: > >>> + description: > >>> + Address and length of the IO space, as well as the address > >>> + and length of the AXI DMA controller IO space, unless > >>> + axistream-connected is specified, in which case the reg > >>> + attribute of the node referenced by it is used. > >> > >> Did you test it with axistream-connected? The schema and description > >> feel contradictory and tests would point the issue. > > > > Thanks for review comments. We tested with axistream-connected and > did > > not observe any errors. Do you anticipate any issues/errors ? > > Yes, I anticipate errors. What you wrote here looks incorrect based on the > schema. > > Also, See also my further comments (or you ignored them?). > > You can come many months after my review to ask about details, to be > sure I will forget the topic.
Hi Krzysztof, Apologies for miscommunication. I replied to this thread on March 28 and said that I would address remaining review comments in the next version.
Lore link: https://lore.kernel.org/all/MW5PR12MB559880B0E220BDBD64E06D2487889@MW5PR12MB5598.namprd12.prod.outlook.com/ https://lore.kernel.org/all/MW5PR12MB5598678BB9AB6EC2FFC424F487889@MW5PR12MB5598.namprd12.prod.outlook.com/
I planned to send next version with phy-mode and pcs-handle maxItems fixed.but I wanted to close on the axistream-connected discussion before doing so.
Related to axistream-connected discussion: I already ran dt binding check for schema and dts node validation. I assume this should point any errors on it.
Thanks, Sarath
| |