Messages in this thread | | | Date | Wed, 3 May 2023 11:26:39 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH blktests v3 01/12] nvme/rc: Auto convert test device size info |
| |
On Wed, May 03, 2023 at 09:22:07AM +0000, Chaitanya Kulkarni wrote: > On 5/3/23 01:02, Daniel Wagner wrote: > > Introduce a convert_to_mb() helper which converts the size argument > > to MBytes and use in test device require function. This makes it > > possible to use user input strings in future. > > > > Reviewed-by: Hannes Reinecke <hare@suse.de> > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > > --- > > > > Much needed mb helper, looks good.
I am sure the helper can be written way smarter but my shell-foo skills are a bit limitted. Still a starting point :)
| |