Messages in this thread | | | Date | Fri, 26 May 2023 18:59:00 +0100 | Subject | Re: [PATCH mm-nonmm-unstable v2 1/2] squashfs: fix page update race | From | Phillip Lougher <> |
| |
On 26/05/2023 14:57, Vincent Whitchurch wrote: > We only put the page into the cache after we've read it, so the > PageUptodate() check should not be necessary. In fact, it's actively > harmful since the check could fail (since we used find_get_page() and > not find_lock_page()) and we could end up submitting a page for I/O > after it has been read and while it's actively being used, which could > lead to corruption depending on what the block driver does with it. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>
| |