lkml.org 
[lkml]   [2023]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 5/6] drm: lcdif: Add multiple encoders and first bridges support
From
On 5/25/23 03:45, Ying Liu wrote:
> Hi Marek,

Hi,

> On Thu, May 11, 2023 at 12:24 AM Marek Vasut <marex@denx.de> wrote:
>> On 5/10/23 11:24, Liu Ying wrote:
>>> The single LCDIF embedded in i.MX93 SoC may drive multiple displays
>>> simultaneously. Look at LCDIF output port's remote port parents to
>>> find all enabled first bridges. Add an encoder for each found bridge
>>> and attach the bridge to the encoder. This is a preparation for
>>> adding i.MX93 LCDIF support.
>>>
>>> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>>> ---
>>> v5->v6:
>>> * Drop MAX_DISPLAYS macro. (Marek)
>>> * Drop the encoder member in struct lcdif_drm_private.
>>> * Drop endpoint id check.
>>
>> It might be nice to check (based on driver data for each IP variant) the
>> encoder count, but that can be a separate patch.
>>
>> Reviewed-by: Marek Vasut <marex@denx.de>
>>
>> Thanks !
>>
>> btw if this doesn't get picked by someone in like a week or two, let me
>> know and I'll apply this via drm-misc .
>
> Thanks for your review. I don't see any more comments in two weeks.
> Can you please go ahead to apply this series?

Done, applied to drm-misc-next , thanks !

Thanks for the reminder too .

\
 
 \ /
  Last update: 2023-05-26 19:11    [W:0.062 / U:2.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site