Messages in this thread Patch in this message | | | Date | Sat, 27 May 2023 07:51:32 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [EXT] [PATCH v4 4/7] PCI: endpoint: Add BME notifier support |
| |
On Fri, May 19, 2023 at 06:19:44PM +0000, Frank Li wrote: > > > @@ -72,11 +72,13 @@ struct pci_epf_ops { > > * @core_init: Callback for the EPC initialization complete event > > * @link_up: Callback for the EPC link up event > > * @link_down: Callback for the EPC link down event > > + * @bme: Callback for the EPC BME (Bus Master Enable) event > > */ > > struct pci_epc_event_ops { > > int (*core_init)(struct pci_epf *epf); > > int (*link_up)(struct pci_epf *epf); > > int (*link_down)(struct pci_epf *epf); > > + int (*bme)(struct pci_epf *epf); > > I posted a doorbell from host to EP at > https://lore.kernel.org/imx/20230426203436.1277307-2-Frank.Li@nxp.com/T/#u > > Can we consider consolidate these notification to one function and distinguished by > EVENT_ID in future? >
My preference is to keep a separate callback for each event as it makes the code look better instead of clubbing everything in a single callback separated by a switch case.
- Mani
> Best regards > Frank Li > > > }; > > > > /** > > -- > > 2.25.1 >
-- மணிவண்ணன் சதாசிவம்
| |