lkml.org 
[lkml]   [2023]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
From
Hi Bryan,

Thanks for your review!

On 5/20/2023 1:56 AM, Bryan O'Donoghue wrote:
> On 19/05/2023 16:56, Jagadeesh Kona wrote:
>> +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver");
>
> This pattern looks odd and inconsistent in our clock drivers. We mostly
> have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC.
>
> I'd drop that underscore to, in addition to Konrad's comment on Ucase hex.
>
> Other than that, LGTM.
>
Will take care of this in next series.

> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Thanks & Regards,
Jagadeesh

\
 
 \ /
  Last update: 2023-05-25 18:52    [W:0.074 / U:3.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site