Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 25 May 2023 22:19:51 +0530 | Subject | Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 | From | Jagadeesh Kona <> |
| |
Hi Bryan,
Thanks for your review!
On 5/20/2023 1:56 AM, Bryan O'Donoghue wrote: > On 19/05/2023 16:56, Jagadeesh Kona wrote: >> +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver"); > > This pattern looks odd and inconsistent in our clock drivers. We mostly > have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC. > > I'd drop that underscore to, in addition to Konrad's comment on Ucase hex. > > Other than that, LGTM. > Will take care of this in next series.
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Thanks & Regards, Jagadeesh
| ![\](/images/icornerr.gif) |