| Date | Wed, 24 May 2023 17:48:17 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 03/30] net: dsa: mt7530: properly support MT7531AE and MT7531BE |
| |
On Mon, May 22, 2023 at 03:15:05PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Introduce the p5_sgmii field to store the information for whether port 5 > has got SGMII or not. > > Move the comment about MT7531AE and MT7531BE to mt7531_setup(), where the > switch is identified. > > Get rid of mt7531_dual_sgmii_supported() now that priv->p5_sgmii stores the > information. Address the code where mt7531_dual_sgmii_supported() is used. > > Get rid of mt7531_is_rgmii_port() which just prints the opposite of > priv->p5_sgmii. > > Remove P5_INTF_SEL_GMAC5_SGMII. The p5_interface_select enum is supposed to > represent the mode that port 5 is being used in, not the hardware > information of port 5. Set p5_intf_sel to P5_INTF_SEL_GMAC5 instead, if > port 5 is not dsa_is_unused_port(). > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Daniel Golle <daniel@makrotopia.org> > ---
Pretty busy patch, and after reading it, I'm not sure:
- why? (this seems to be absent from the commit message) - how are MT7531AE and MT7531BE supported any more properly after this change, as the commit title claims - what is the overall effect, other than just refactoring. If that's all, what's written on the tin needs to be a better representation of what's inside.
Pure refactoring is not a bad goal in itself, as long as we're on the same page that there is a justification which makes the new code better than the old one.
|