lkml.org 
[lkml]   [2023]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 06/11] iommufd: IOMMU_HWPT_ALLOC allocation with user data
Date
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Saturday, May 20, 2023 3:48 AM
>
>
> > >
> > > + switch (pt_obj->type) {
> > > + case IOMMUFD_OBJ_IOAS:
> > > + ioas = container_of(pt_obj, struct iommufd_ioas, obj);
> > > + break;
> >
> > this should fail if parent is specified.
>
> I don't think that's necessaray: the parent is NULL by default
> and only specified (if IOMMUFD_OBJ_HW_PAGETABLE) by the exact
> pt_id/pt_obj here.

I didn't get. The uAPI describes that only hwpt not ioas can be specified
in the pt_id field as the parent.

If we don't check here it means the user can specify an ioas id as the
parent?

\
 
 \ /
  Last update: 2023-05-24 07:17    [W:0.111 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site