Messages in this thread | | | Date | Wed, 24 May 2023 09:51:00 +0100 | Subject | Re: [PATCH 1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag | From | Srinivas Kandagatla <> |
| |
On 23/05/2023 17:55, Mark Brown wrote: > On Tue, May 23, 2023 at 04:46:04PM +0100, Srinivas Kandagatla wrote: >> regmap-sdw does not support multi register writes, so there is >> no point in setting this flag. This also leads to incorrect >> programming of WSA codecs with regmap_multi_reg_write() call. > >> This invalid configuration should have been rejected by regmap-sdw. > > Does the CODEC support mulitple writes? If so it seems better to leave No, the codec itself does not support multi-write. All the codec register level interface is via SoundWire Bus. which also does not support with the existing code.
--srini
> the flag set and just do the appropriate fix in the regmap code until > such time as it's updated to be able to exercise it.
| |