Messages in this thread | | | Date | Wed, 24 May 2023 14:57:05 +0800 | Subject | Re: [PATCH -next] cgroup: Remove out-of-date comment in cgroup_migrate() | From | Xiu Jianfeng <> |
| |
On 2023/5/24 3:09, Tejun Heo wrote: > On Tue, May 23, 2023 at 07:14:56PM +0800, Xiu Jianfeng wrote: >> From: Xiu Jianfeng <xiujianfeng@huawei.com> >> >> Commit 674b745e22b3 ("cgroup: remove rcu_read_lock()/rcu_read_unlock() >> in critical section of spin_lock_irq()") has removed the rcu_read_lock, >> which makes the comment out-of-date, so remove it. >> >> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> > > So, that removed rcu_read_lock() because it's implied by the irq disable but > the comment content is still useful in describing what's preventing > use-after-free. Can you please update the comment accordingly instead?
sure, I would send a v2.
> > Thanks. >
| |